file is not closed in some cases

[Jian Wang]

The file is not closed in all cases.

And there are some similar functions have such issue, e.g. unbindPCIDeviceFromDriver, unbindPCIDeviceFromVfioPCIDriver, please check and update.

func addNewIdToVfioPCIDriver(vendorId string, deviceId string) error {
	var id string = fmt.Sprintf("%s %s", vendorId, deviceId)

	file, err := os.OpenFile("/sys/bus/pci/drivers/vfio-pci/new_id", os.O_WRONLY, 0400)
	if err != nil {
		return err
	}
	_, err = file.WriteString(id)
	if err != nil {
		return err   // the file is not closed in this return
	}
	file.Close()
	return nil
}

Found when reviewing: #14

[Tobi Lehman]

Fixed in

pcidevices/pkg/controller/pcideviceclaim/pcideviceclaim_controller.go

Lines 87 to 103 in 3d85f9a

 func bindDeviceToVFIOPCIDriver(pd *v1beta1.PCIDevice) error { 
 	vendorId := pd.Status.VendorId 
 	deviceId := pd.Status.VendorId 
 	var id string = fmt.Sprintf("%s %s", vendorId, deviceId) 
  
 	file, err := os.OpenFile("/sys/bus/pci/drivers/vfio-pci/new_id", os.O_WRONLY, 0400) 
 	if err != nil { 
 		return err 
 	} 
 	_, err = file.WriteString(id) 
 	if err != nil { 
 		file.Close() 
 		return err 
 	} 
 	file.Close() 
 	return nil 
 } 

[Jian Wang]

Please double check unbindDeviceFromDriver

func unbindDeviceFromDriver(addr string, driver string) error {
	path := fmt.Sprintf("/sys/bus/pci/drivers/%s/unbind", driver)
	file, err := os.OpenFile(path, os.O_WRONLY, 0400)
..
	_, err = file.WriteString(addr)
	if err != nil {
                // file should be closed 
		return err   ////
	}
..
}

General practice in go is:

func unbindDeviceFromDriver(addr string, driver string) error {
...
	file, err := os.OpenFile(path, os.O_WRONLY, 0400)
..
       // after successfully OpenFile
       defer file.Close()   /// it will make sure, in any return path, file is closed

	_, err = file.WriteString(addr)

        // do NOT need any file.Close
...
..
}

[Tobi Lehman]

Fixed in f10b170