Memory leak and potential fix

Question

Memory leak and potential fix

davidsandberg opened this issue 5 years ago · comments

Hi @hardmaru!
Thanks for a great repo and a really cool project!!
I was running the 'carracing' experiment but experienced memory problems. This was caused by new tensorflow assign operations being created every time set_model_params (in rnn.py and vae.py) is called.
I implemented a fix where the assign operations were created when the graph was built and used when setting the parameters.
If you are interested in a fix I can make a PR, or you simply just copy and paste the fix from here (look at the diffs in rnn.py and vae.py).

hardmaru · Answer 1 · Wed Dec 26 2018 06:38:21 GMT+0800 (China Standard Time)

Thanks for identifying the leak! Can you do a favor and create a PR?

…

On Wed, Dec 26, 2018 at 6:41 AM David Sandberg ***@***.***> wrote: Hi @hardmaru <https://github.com/hardmaru>! Thanks for a great repo and a really cool project!! I was running the 'carracing' experiment but experienced memory problems. This was caused by new tensorflow assign operations being created every time set_model_params (in rnn.py and vae.py). I implemented a fix where the assign operations were created when the graph was built and used when setting the parameters. If you are interested in a fix I can make a PR, or you simply just copy and paste the fix from here <davidsandberg@c31e8d8...e759ffc> (look at the diffs in rnn.py and vae.py). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGBoHui1d97sshNhAUMzvyWuMAUD9yuhks5u8puGgaJpZM4ZhOVY> .