haradakunihiko / react-confirm

Small library which makes your Dialog component callable.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

removeChild called twice and rise an exeption

umbrella-ivan-zhukov opened this issue · comments

dispose() function is called twice and tried to delete already deleted div.

createConfirmation.js:43 Uncaught DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.

Video: http://take.ms/yQoLQ

Downgrading from 0.1.17 to 0.1.16 solves the problem http://take.ms/eC2WG.

hmm.. I can't reproduce this issue.
Could you share some code to reproduce this or try my react example if it still happens on your environment?
(Note that the dependency for react-confirm is locked to 0.1.16 on the example.)

@haradakunihiko could you please try to launch the example with 0.1.17 version? I think the issue is 90% there )

@umbrella-ivan-zhukov yeah, I did try the react example with 0.1.17 and still can't see the exception.
Did you mean you could reproduce that with the example with 0.1.17 version?

I get the same error. The method dispose is invoked twice. You can see the screenshots here:
image
image

How can I help?

@krnlde I can't say properly if it's related only with bootstrap, or if it's really your case, but I fixed by removing the onClosed function on the creation of my component.

captura de tela 2019-03-01 as 10 29 34

I created a PR for solving it #27

Thanks! I accept your PR and publish new version to npm.