React-confirm using really old react dependency

Question

React-confirm using really old react dependency

vesakilp opened this issue 7 years ago · comments

Used react dependency is really old, and leads to problems with shrinkwrap, basically it can't be used when using new react versions.

Joshua Comeau · Answer 1 · Mon Sep 04 2017 21:45:46 GMT+0800 (China Standard Time)

Yeah, I'm using it with React 16 and it works without issue (really great project, by the way, @haradakunihiko!). Should be a simple matter of incrementing the peerDependency to ^0.14.7 || 15.x || 16.x

KunihikoHarada · Answer 2 · Tue Sep 05 2017 09:30:03 GMT+0800 (China Standard Time)

Thanks for using react-confirm. I'd really like to modify and also update the example to use the latest React version, but currently have no time for this.
Could you kindly create a PR for this if possible?

Joshua Comeau · Answer 3 · Tue Sep 05 2017 19:32:04 GMT+0800 (China Standard Time)

Sent a quick PR that adds the peer dependency update, and changes the example in the README to use prop-types package (since PropTypes is no longer included in React).

I just saw that there are also a couple example apps, which I realize now is probably what you meant by "update the example", but I'm afraid I don't quite have time for that. FWIW, I don't believe anything else needs to change other than moving PropTypes and createClass (if used) into separate packages.

KunihikoHarada · Answer 4 · Sun Sep 17 2017 21:56:22 GMT+0800 (China Standard Time)

Thanks for the PR, your comment was helpful since I haven't used react for a while.
Merged and published. (Maybe I will release again once react@16 are published. )