valid_validator_sig_transacitons

Question

valid_validator_sig_transacitons

Hongchenglong opened this issue 8 months ago · comments

I find a bug in main.py, there are two valid_validator_sig_transacitons in line 690.

I think maybe one of them should be invalid_validator_sig_transacitons.

Hang Chen · Answer 1 · Sun Oct 22 2023 19:20:41 GMT+0800 (China Standard Time)

Thank you for the bug report again, Hongchenglong! Yes, that's indeed wrong, and it's most likely should be invalid_validator_sig_transacitons. I actually never simulated any transactions having invalid signatures so I guess that's how I missed it. Sorry for the confusion.

Do you prefer to create a PR or let me change and push? Please let me know, thanks!

Hongchenglong · Answer 2 · Sun Oct 22 2023 21:21:31 GMT+0800 (China Standard Time)

Sure, this is my PR #11.

Hang Chen · Answer 3 · Tue Oct 24 2023 03:56:38 GMT+0800 (China Standard Time)

Thanks for keeping the VBFL codebase improved, @Hongchenglong!