hand-dot / labelmake

labelmake has moved and now available at pdfme / https://github.com/pdfme/pdfme

Home Page:https://labelmake.jp/javascript-pdf-generator-library

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

compatibility with node >14

dartess opened this issue · comments

Hi!

How you have

  "engines": {
    "node": "14.x"
  },

Does this mean that the package is incompatible with other versions?

If not, is it possible to replace the entry with ">=14" or at least "14.x 16.x"?

@dartess
Hi

I've only tested it on node14, so that's how I've described it.

@hand-dot
Are there any plans to test in other versions? Do you need any help with this?

It also seems to me that the likelihood of a lack of backward compatibility in new releases of Node.js now is extremely small. Therefore, specifying the version as ">=14" seems perfectly acceptable. The worst that can happen is that the library users open the issue with the problem. At the same time, now more and more new users will come from version 16, which is LTS now. And they will receive a version mismatch warning on installation, although the library itself will most likely work correctly. Also, all users who plan to use the library in a browser receive a false message about incompatibility. But this is just my opinion, I do not impose it and is ready to help with testing if necessary.

@dartess
Thank you!
I understand.
I'll run the tests on node 16 and if there are no problems, I'll release with the new minor change version within a few days.

@dartess
Published as Version 2.0.20!

Thanks for the suggestion!