Giters

hanatos / vkdt

raw photography workflow that sucks less

Home Page:https://vkdt.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

masking/usability proposals

Heddesdorfer opened this issue · comments

commented

Preamble
I don't know, if all of this points are really new, or if I just didn't have seen how to do...nevertheless

  1. If you want to use masking, you have to add more than one module. It would be nice to be able to choose more than module in the dialog before it will be closed.
  2. If you want to mask another part, it would be helpful if you could copy and past the modules in the node editor, preserving inner and outer connections, but without changed parameters.
  3. 'undo masking' is also a nice to have.
  4. If I use the standard cfg, some names like 'display: main' or 'display:hist' are set, but I see no possibility to give modules a meaningful name.
commented

thanks for these observations. i assume you found the related links in the docs?

https://vkdt.org/doc/howto/draw-masks/readme.html
https://vkdt.org/src/pipe/modules/draw/readme.html
https://vkdt.org/src/pipe/modules/mask/readme.html

i think they are slightly outdated now, i should update them. how are you masking? draw, mask or grad module?

  1. yis. i think this should be realised via presets (ctrl-p should show dodge or burn as it does for inpaint.pst and retouch.pst) the advantage would be that the connections etc are useful out of the box, too.
  2. you can add another stroke in the draw module..
  3. ..and remove it by right clicking, if that is what you mean? of course there's the ctrl-h history stack in the left panel too.
  4. right. you can't rename instances. is that a useful feature? you can name the module when adding it (the first textbox in the ctrl-m popup, "instance"). changing it after the fact seemed not very interesting to me (prove me wrong!) and it's a delicate thing to do in the processing history.

from the discussion so far i see the following action items:

  • update mask/draw docs
  • introduce copy/paste node selection in graph editor
  • introduce presets for common masked edits (dodge/burn, what else?)
commented

Yes, I found the links - and because I'm impatient I tried the draw-guided.cfg from the example.
ad 2: but then both strokes would be handled in the same way, what if the second one needs e.g. an other exposure?
ad 3: ah! I must have overseen these control-thingies description.
ad 4: I didn't realize that "instance" is used for naming - that's sufficient.

commented

I just tried dodge & burn presets, works well.
But the modules are strangely listed in darkroom mode:
modules

If I need another instance of dodge / burn (because of another degree of exposure), the preset doesn't work.
But that might be a feature beyond raw processing.

commented
commented
commented

Works!
What's now ...irritating... when I start vkdt, it starts in full screen mode. What means, I have to press F11 to move it to another monitor, where I can enlarge it. I know, that's not really an error, but if something changes "suddenly"...

I work on my notebook, and programs start on this monitor. If available, I use an external one, so I have to move vktd. So it may be a my personal inconvenience.

commented