halfzebra / create-elm-app

πŸƒ Create Elm apps with zero configuration

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Move elm-asset-webpack-loader to dependencies

andys8 opened this issue Β· comments

commented

Hey @halfzebra

Webpack dependencies are normally dev dependencies. But in the case of create-elm-app: Does it need a to be a normal dependency? I think so...
(Couldn't try it so far)

"elm-asset-webpack-loader": "1.1.1",

slack quote

Screenshot_20191106-115534

Good point, it's kinda hard to catch this kind of regression without reworking the test setup so create-elm-app and tests don't share dependencies.

Thanks for fixing this! πŸ‘

πŸŽ‰ This issue has been resolved in version 4.1.1 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

commented

Sorry for the trouble and thanks for the quick release :)

By the way, we could use it the example template but I'm not sure if it's the best idea. For beginners this type of custom syntax is maybe solving a problem they don't have.