🐞 - Backdrop taller than scroll container when anchor element exceeds scroll container's height
EliotRagueneau opened this issue · comments
Which ngx-ui-tour-* package is the source of the bug?
md-menu
Please provide a link to a minimal reproduction of the bug
https://stackblitz.com/edit/angular-wau2z8-8rzdo3?file=src%2Fapp%2Fui-tour-demo.component.ts
Description
If you have an anchored element inside a scrollContainer, and that scrolContainer is smaller than the anchored element, then the backdrop adjust itself to the absolute position of the anchored element, and not relative to its scrollContainer.
Expected behaviour: If step has scrollContainer, then the backdrop area should be the overlap of scrollContainer and the anchored element
Angular version
15.2.3
Ngx UI Tour version
10.0.0
Which browsers have you used?
- Chrome
- Firefox
- Safari
- Edge
Which operating systems have you used?
- macOS
- Windows
- Linux
- iOS
- Android
Just put the tourAnchor on your scroll container in this case. Seems to fix the issue in your demo.
Anyway, I don't think this is a major issue but if you can provide a simple and elegant way to fix this, feel free to open a PR with your solution.
Well in this specific example it would work indeed, but it wouldn't if you have more than one element in the scrollContainer. When I have a bit of time I'll try to implement a fix
I have released v11.0.5.