haberman / dblbook

Double-Booked: a Chrome app for double-entry accounting.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Flow errors at gulp

buildog opened this issue · comments

Hey @haberman

I'm trying to install the project but I got an error from flow at gulp:

[11:15:02] Error in plugin 'flow'
Message:
    model/importGnucash.js:88
 88:   let accounts = xml.getElementsByTagNameNS(gnc, "account");
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ call of method `getElementsByTagNameNS`. Function cannot be called on any member of intersection type
 88:   let accounts = xml.getElementsByTagNameNS(gnc, "account");
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ intersection
  Member 1:
  389:     getElementsByTagNameNS(namespaceURI: string, localName: 'a'): HTMLCollection<HTMLAnchorElement>;
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ function type. See lib: /private/tmp/flow/flowlib_21e8a862/dom.js:389

I also had to update the flow-bin dependency to ^0.24.2 because it was missing the vendor folder.

Would be pleased to join the contribution program but I'd like to test it before :-)

Hi there, sorry I missed this when you first filed it!

Flow seems to be getting confused here. Unfortunately I don't have time at the moment to fix this, but fixes are welcome (or even disabling flow for these cases)!