haarnoja / sac

Soft Actor-Critic

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

could there be a problem with the initialization of GaussianPolicy ?

guyk1971 opened this issue · comments

GaussianPolicy inherits from NNPolicy and in the end of GaussianPolicy constructor (init) there is a call to the parent of NNPolicy...
shouldnt it be :
super(GaussianPolicy,self).__init__(env_spec)

I observed its repeating in latent_space_policy and gmm_policy as well (although there is a comment in gmm_policy about it).

so not sure its a mistake, probably my misunderstanding, but sending anyway.
Thanks for sharing the code :)