Typography Fixes based on Twitter Feedback
haacked opened this issue · comments
- Title in sidebar can overflow at times
- Decrease font size for mobile
I think the font itself is really nice and super readable.
Along the lines of overflow, I noticed the below -- figured may be related or its own thing:
@SeanKilleen I can't repro the overflow. What conditions lead to it? Browser, OS, etc?
@SeanKilleen nevermind, I see it.
👍 Fixed now as far as I can see.
Only thing I see now is that the "d" is a little cut off:
(I'm on Chrome latest stable with a Dell XPS 15 on Win 10 v1809 btw)
Thanks @SeanKilleen! I'll have to try this on my son's computer when I get home. Looks fine on a Mac.
I just pushed a change to the theme that should fix this: haacked/haackbar#14
I had to push a much needed change to my About page to trigger a rebuild. It should be done in a few seconds.
So I think this is fixed now. @SeanKilleen how does it look to you?
@haacked I killed my cache but I'm still seeing it:
It definitely looks better -- I can tell it's a d, but still bleeds past the sidebar.
@SeanKilleen could you take one more look. I decided to use a Google web font so that it's the same font on both Mac and Windows.
Looks to still be the case. Cleared the cache and checked.
Here's the computed style options in case that helps:
If I drop the font size from 63px in Chrome to 56 or 57, it appears to fix it.
Ok, I finally fixed it. Turns out it was a dumb mistake. I had the URL format for the Open Sans Condensed URL incorrect so it wasn't actually rendering that font. haacked/haackbar#15
Looks great!
