Contribute to the project
ngryman opened this issue · comments
Hi guys,
I proposed a few month ago a big refactoring for the node implementation of the h5bp server configs.
I was wishing it would become a more attractive and better tested project.
Nowadays I can see that tests don't even run and the project does contains major bugs that make it unusable :'(
So I would like to propose myself to become an official contributor, and eventually one of the maintainers for this project.
What do you think about that ?
I thought you are working with Paul Irish to finish with all web configs, cause you know, he and his colleagues prepared the .htaccess for the popular h5bp. If you are advanced enough as I'm not, I'm ok with that 👍
I'm not sure what was up with the rewrite, didn't test it, I assumed it should be pulled in, although it was a major refactor so we probably should modularize this more like an API. I believe I pulled all your stuff in and published it in NPM v0.0.3 https://npmjs.org/package/h5bp. This repo is not up to date, and I'm not sure why my pull request wasn't added.
hey @ngryman see my repo here https://github.com/niftylettuce/node-h5bp this needs merged with your pull request and the package.json file needs updated, along with Readme to match my repo
I pulled your pull request in. After, I responded to it, asking you to complete it. I asked you for docs and documentation on the tests. I reviewed your commit ran it through lint and filled some of the @todos. After that I never heard from you again, and no one stepped up to maintain your re-write. We had maybe only 2 pull requests since then and none of them was from you. Ever since it has been on my list to address the issues reported and to try to make sense of the code you contributed.
If you becoming the maintainer means that you will stand behind your work and contribute to make this project reliable then I think you are right and you should take over. But if you intend to make an appearance every 6 months (assuming from your current behavior) then I think you should re think your request.
Let me know if you are ready to commit and if you are, I'll gladly pass the torch. I will still contribute to the project under your guidance.
First, I didn't mean to offend you.
My original pull request is here. It was merged after 3 months, not because I didn't show up, but because of some lack of reactivity.
Feedback was quite long, and I have to admit that 3 months later I was a little frustrated and stop contributing.
I love h5bp since the begining, and I am really motivated to be a little part of it. That's why, instead of creating a new repo of my own I decided to share it w/ you guys.
I will propose you another pull request fixing bugs and cleaning stuff, and I hope you will re think my request.
You miss understand me, I'm not offended nor aggravated.
I'm sorry your pull request sat there for 3 months, but I needed to ask the people who use the project for their opinion and if it was ok to break backwards compat. And give other mods the chance to review your (extensive) changes. After enough time went by your pull request was accepted. If you intent to lead this project you will need to consider more that your own use for it. You will need to think about the others who use the project. Frustration is common and at times hard to deal with but trust me, you will be frustrated again, specially if you still desire to write code for others.
Let's focus on improving the project, from this point on you are a member of the team with the same rights as all of us. Let's see some code. 👍
Unless someone had anything else to say, this thread is closed.
Thanks :)
I will push a fix this WE.
sounds good. thanks guys