An official docker container to serve this repo
pierreozoux opened this issue · comments
Hi,
I'm always searching for the most efficient docker nginx container to serve static.
I found these 2 projects:
- https://github.com/KyleAMathews/docker-nginx/
- https://github.com/dreamcat4/docker-images/tree/master/nginx
But I think it would be cooler if it is part of this organisation.
Can I join the organisation and create a repo for me:
h5bp/docker-nginx-static
The purpose would be to serve /var/www as fast as possible!
We might need to rework on this repo too.
What do you think?
I am not entirely sure if it would be a great idea to directly host this configuration. To me it serves as a good resource of examples, but not as a boilerplate nginx configuration.
What do you think?
I don't use docker personally, Is there a lot of demand for a static-content nginx docker setup?
it serves as a good resource of examples, but not as a boilerplate nginx configuration.
It's actually designed to function for both:
- https://github.com/h5bp/server-configs-nginx/blob/master/doc/usage.md#using-as-a-reference
- https://github.com/h5bp/server-configs-nginx/blob/master/doc/usage.md#using-directly
May I ask why you don't think it's suitable as a boilerplate config?
This repository serves as a great example with documentation on how to do things well in nginx, so for me it really acts more as documentation than actual configuration.
In fact, while the explanation with every setting is amazing, in reality it clutters up the configuration as a whole.
IMHO it's better to explicitly include the settings you need, optionally referring to wherever it came from in this repository.
However, when you're still new to nginx, I admit cloning and using this directly is probably the best you can do.
Let me add some arguments on why serving this repo as a Docker image is not so relevant:
- This repo is basically only static configuration files, you can easily mount a volume to the right place without building a custom image;
- This repo contains some working default vhost files, but basically require changing and/or adding configurations to feet your needs, which makes built images less useful;
- The demand may be quite small, since a lot application-ready Docker image already bring nginx, and use both a "forked" raw nginx container plus an application Docker image would overkill a simple volume;
- The official nginx image already explain well how to handle custom configuration;
- The last but not the least: to cover all nginx versions & supported architectures, this would increase quite a lot maintenance.