Again C99 build error on FreeBSD

Question

Again C99 build error on FreeBSD

utrenkner opened this issue a year ago · comments

On Friday, I wanted to test the new fix for "handling of headers appearing more than once" (#3185). However, I could not get over a C99 error on FreeBSD 13.1-RELEASE-p5, which looks similar to earlier problems (#2933 , #2944). I tried further today, but without luck:

/home/uwe/test/h2o/deps/neverbleed/neverbleed.c:1302:11: error: implicit declaration of function 'pthread_setaffinity_np' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
    ret = pthread_setaffinity_np(pthread_self(), sizeof(NEVERBLEED_CPU_SET_T), &cpuset);
          ^

Does anyone know how to work around this?

Uwe Trenkner · Answer 1 · Thu Feb 16 2023 19:06:07 GMT+0800 (China Standard Time)

@dch @kazuho You solved similar problems, in the past. May I kindly ask you to have a look at this issue? Maybe it can be fixed rather easily, based on your previous solutions?

Uwe Trenkner · Answer 2 · Tue Mar 07 2023 20:05:22 GMT+0800 (China Standard Time)

@dch @kazuho I am not a developer, but to me it looks as if the solution used in main.c could be adapted for neverbleed.c.

Kazuho Oku · Answer 3 · Mon Apr 24 2023 09:27:44 GMT+0800 (China Standard Time)

Hey sorry for the delay, I think the issue has been addressed now, with #3220 incorporating h2o/neverbleed#56.

Uwe Trenkner · Answer 4 · Mon Apr 24 2023 23:27:11 GMT+0800 (China Standard Time)

@kazuho Many thanks - I confirm that both problems are solved (wrong folding of set-cookie fields, C99 error)!

Dave Cottlehuber · Answer 5 · Tue Apr 25 2023 02:35:44 GMT+0800 (China Standard Time)

awesome! shall I just bump the port to the next master version?

Uwe Trenkner · Answer 6 · Tue Apr 25 2023 15:51:00 GMT+0800 (China Standard Time)

@dch That would be great! I managed to modify the current version of www/h2o-devel for the latest commit 43cf4e6. I successfully built the package from this version. I'll send you my patch directly, because GH somehow does not let me attach it here.

Kazuho Oku · Answer 7 · Thu Apr 27 2023 21:35:58 GMT+0800 (China Standard Time)

Hey sorry for the inconvenience.

As you may have noticed, we have a vulnerability fix that has to be merged; please see GHSA-p5hj-phwj-hrvx.

@dch I would appreciate it if you could pick that up as well.

FWIW regarding the release model, I am sorry that we are failing to make releases, I had recently started my work to transition to a new model; please see #3230.

Uwe Trenkner · Answer 8 · Thu Apr 27 2023 23:41:10 GMT+0800 (China Standard Time)

@Kazuhu Thank you for the heads-up concerning the security patch.

@dch I have just sent you my updated patch for www/h2o-devel including the security relevant commit. I do not know how you want to deal with www/h2o, though. You may have to bring that to the latest patch level as well. Maybe with the new release model, the -devel port becomes obsolete anyway?