Giters

guzzle / guzzle

Guzzle, an extensible PHP HTTP client

Home Page:https://docs.guzzlephp.org/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Deprecations causing test failures in PHP 8.4

rugk opened this issue · comments

commented

Guzzle version(s) affected: 7.8.1
PHP version: 8.4.0-dev (039344cf70f52086c9d3b486ea035745b3aaa8c0)
cURL version: unsure (not logged in the tests)

Description

Under PHP 8.4. our tests seem to fail due to Guzzle using some deprecated PHP features.
Full test run: https://github.com/PrivateBin/PrivateBin/actions/runs/8949790421/job/24584480718?pr=1302

How to reproduce

Just include it and run some tests. (I am not sure on the exact steps.)

Warning: PHP Deprecated:  GuzzleHttp\Client::getConfig(): Implicitly marking parameter $option as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/PrivateBin/PrivateBin/vendor/guzzlehttp/guzzle/src/Client.php on line 205
Warning: PHP Deprecated:  GuzzleHttp\ClientInterface::getConfig(): Implicitly marking parameter $option as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/PrivateBin/PrivateBin/vendor/guzzlehttp/guzzle/src/ClientInterface.php on line 83
Warning: PHP Deprecated:  GuzzleHttp\HandlerStack::create(): Implicitly marking parameter $handler as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/PrivateBin/PrivateBin/vendor/guzzlehttp/guzzle/src/HandlerStack.php on line 47
Warning: PHP Deprecated:  GuzzleHttp\HandlerStack::__construct(): Implicitly marking parameter $handler as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/PrivateBin/PrivateBin/vendor/guzzlehttp/guzzle/src/HandlerStack.php on line 61
Warning: PHP Deprecated:  GuzzleHttp\HandlerStack::unshift(): Implicitly marking parameter $name as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/PrivateBin/PrivateBin/vendor/guzzlehttp/guzzle/src/HandlerStack.php on line 134
Warning: PHP Deprecated:  GuzzleHttp\Handler\StreamHandler::invokeStats(): Implicitly marking parameter $response as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/PrivateBin/PrivateBin/vendor/guzzlehttp/guzzle/src/Handler/StreamHandler.php on line 82
Warning: PHP Deprecated:  GuzzleHttp\Handler\StreamHandler::invokeStats(): Implicitly marking parameter $error as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/PrivateBin/PrivateBin/vendor/guzzlehttp/guzzle/src/Handler/StreamHandler.php on line 82
Warning: PHP Deprecated:  GuzzleHttp\Middleware::httpErrors(): Implicitly marking parameter $bodySummarizer as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/PrivateBin/PrivateBin/vendor/guzzlehttp/guzzle/src/Middleware.php on line 58
Warning: PHP Deprecated:  GuzzleHttp\Middleware::tap(): Implicitly marking parameter $before as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/PrivateBin/PrivateBin/vendor/guzzlehttp/guzzle/src/Middleware.php on line 135
Warning: PHP Deprecated:  GuzzleHttp\Middleware::tap(): Implicitly marking parameter $after as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/PrivateBin/PrivateBin/vendor/guzzlehttp/guzzle/src/Middleware.php on line 135
Warning: PHP Deprecated:  GuzzleHttp\Middleware::retry(): Implicitly marking parameter $delay as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/PrivateBin/PrivateBin/vendor/guzzlehttp/guzzle/src/Middleware.php on line 179
Warning: PHP Deprecated:  Google\Auth\HttpHandler\HttpHandlerFactory::build(): Implicitly marking parameter $client as nullable is deprecated, the explicit nullable type must be used instead in /home/runner/work/PrivateBin/PrivateBin/vendor/google/auth/src/HttpHandler/HttpHandlerFactory.php on line 34

and more: https://gist.github.com/rugk/663bffcccf3b279b25d1826503bbc89e

Possible Solution

N/A

Additional context

Project/tests of https://github.com/PrivateBin/PrivateBin

Downstream issue: PrivateBin/PrivateBin#1301

commented

Thanks for getting in touch. This issue has already been fixed in #3203, and will be included in a release before PHP 8.4.0 is released.