BC break in version ^7

Question

BC break in version ^7

camohub opened this issue a year ago · comments

Guzzle version(s) affected: 7.7
PHP version: 7.4

Description
It seems you made a BC break in some of the latest 7.x versions. I have a Cloudinary library which uses Guzzle version ^7.
This means any minor version of package under the major version 7. But minor versions should not include BC breaks. Can you fix it?

The error message says:
Call to undefined function GuzzleHttp\Promise\promise_for()

Graham Campbell · Answer 1 · Tue May 23 2023 17:34:20 GMT+0800 (China Standard Time)

Thanks for getting in touch, but this is not a BC break. This is a bug in the Cloudinary library because it is using the guzzlehttp/promises library without actually requiring it.

Graham Campbell · Answer 2 · Tue May 23 2023 17:41:10 GMT+0800 (China Standard Time)

cloudinary/cloudinary_php#385 should fix your issue.

Graham Campbell · Answer 3 · Tue May 23 2023 17:41:42 GMT+0800 (China Standard Time)

You also already opened this issue already. I don't appreciate the double issue.

camo · Answer 4 · Tue May 23 2023 18:03:58 GMT+0800 (China Standard Time)

Cloudinry use promisses without actually requiring it? Dont understand. It called the method which did exists till now and now it is not. It seems like a BC break on your side.

Graham Campbell · Answer 5 · Tue May 23 2023 19:10:42 GMT+0800 (China Standard Time)

This is not a BC break. Had they correctly required the promises library v1, they would not have experienced this issue.