guzba / supersnappy

Dependency-free and performant Nim Snappy implementation.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Supersnappy can raise an unlisted exception

Clonkk opened this issue · comments

Using supersnappy with Nim 1.6.0 devel :

/home/rcaillaud/.nimble/pkgs/supersnappy-2.1.1/supersnappy.nim(323, 56) template/generic instantiation from here
/home/rcaillaud/.nimble/pkgs/supersnappy-2.1.1/supersnappy.nim(341, 35) Error: newSeq(16384) can raise an unlisted exception: Exception

I am not seeing this with Nim 1.6.0 myself. What is your nim command and do you possibly have any flags / features enabled possibly changing behavior? For example, does a simple nimble test run?

It only happens if you compile with --gc:orc.

Hm, interesting. Thanks for the info. It seems odd to me --gc:orc makes newSeq raise a generic "Exception". I wonder why that is. Will need to take a look.

I added a bunch more test runs to Github Actions and am still not seeing any issues with --gc:orc and Nim 1.6 (or any other version). See this commit: 8deba1f and these runs: https://github.com/guzba/supersnappy/runs/4305537686?check_suite_focus=true

Are you certain you're on stable 1.6? What OS are you seeing this on?

Supersnappy is at commit 62a7e2c (I pulled your latest, but I had the same behaviour with tag v2.1.1).

OS is Ubuntu; Nim compiler is devel (v1.6.0 seems to work, I forgot I was using devel )

Nim Compiler Version 1.7.1 [Linux: amd64]
Compiled at 2021-11-15
Copyright (c) 2006-2021 by Andreas Rumpf

git hash: 6976d18519d102c9cc857a84a4b10b009c1e1a38

Their CI doesn't use 1.6.1 and they don't test 1.7.1.

Closing this. It's old and was a devel issue. Reopen if still relevant.