Extremely slow for large files

Question

Extremely slow for large files

Nudin opened this issue 2 years ago · comments

Michael F. Schönitzer commented 2 years ago

Describe the bug
I tried to use the hosts file from StevenBlack with hostctl. When importing it, it takes 16 minutes.

To Reproduce
Steps to reproduce the behavior:

curl https://raw.githubusercontent.com/StevenBlack/hosts/master/hosts > hosts.adblock
sudo hostctl -q add adblock --from hosts.adblock

Expected behavior
I expected it to be imported in a number of seconds.

System (please complete the following information):

OS: Linux
Version: latest Arch

Michael F. Schönitzer · Answer 1 · Wed Jun 22 2022 18:40:40 GMT+0800 (China Standard Time)

After importing this, all operations take that long…

Gustavo Marin · Answer 2 · Wed Jun 22 2022 22:18:07 GMT+0800 (China Standard Time)

Hi @Nudin the file is 3.25Mb of entries. This tool may no be the best for this task, as it is parsing the whole file each time you run a command. It'll need to be re-written entirely to handle that kind of content.