guptarohit / cryptoCMD

Cryptocurrency historical price data library in Python. Data from https://coinmarketcap.com.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

non-unique symbols issue

vincentweiss96 opened this issue · comments

This is a(n):

  • New feature
  • Update to an existing feature
  • Error
  • Proposal to the Repository

Details:

When using "get_coin_id(coin_code)" from utils with the symbol CTK:

https://web-api.coinmarketcap.com/v1/cryptocurrency/map?symbol=CTK

The api returns a json including 2 coins, since the CTK symbol is used for two different coins.
The function returns: "json_data["data"][0]["slug"]" , so only the first coin is processed. But shoul only be a minor problem since in most cases the coin symbol should be unique.

Api output below.
Kind regards
Vincent


{"status":{"timestamp":"2022-05-11T18:17:38.133Z","error_code":0,"error_message":null,"elapsed":13,"credit_count":0,"notice":null},

"data":[
{"id":4807,"name":"CertiK","symbol":"CTK","slug":"certik","rank":370,"is_active":1,"first_historical_data":"2020-10-21T08:40:00.000Z","last_historical_data":"2022-05-11T18:05:00.000Z","platform":null},
{"id":4596,"name":"Cryptyk Token","symbol":"CTK","slug":"cryptyk-token","rank":null,"is_active":0,"platform":{"id":1,"name":"Ethereum","symbol":"CTK","slug":"cryptyk-token","token_address":"0x42a501903afaa1086b5975773375c80e363f4063"}}]}