guoqiangqi / PFLD

Implementation of PFLD A Practical Facial Landmark Detector , reference to https://arxiv.org/pdf/1902.10859.pdf

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

degrees or radians?

renderless opened this issue · comments

calculate_pitch_yaw_roll returns head pose in degrees but tf.cos() receive radians. will this be an issue?

commented

calculate_pitch_yaw_roll -> degrees
tf.cos(radians )
But I don't think it has any effect.

commented

I think it is ok to just keep the output of calculate_pitch_yaw_roll and the input of tf.cos in the same unit, in spite of whether the unit is degree or radian.Of course it's better to use radians

I think it is ok to just keep the output of calculate_pitch_yaw_roll and the input of tf.cos in the same unit, in spite of whether the unit is degree or radian.Of course it's better to use radians

even if use radians, still there might be some problem with the cos function , like cos(abs(0.6-0.5))= cos(abs(0.6-(0.5+2*pi))), the problem would be more serious using degree i guess

commented

maybe the angle needs to be normalized before computing