gunta / grunt-manifest

Generates HTML5 Cache Manifest files

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

No hash written to manifest file

ain opened this issue · comments

There's no hash written to the manifest file on following configuration:

manifest: {
  dist: {
    options: {
      basePath: '<%= yeoman.dist %>/',
      cache: [],
//          network: ['*', 'http://*', 'https://*'],
      network: ['http://*'],
//          fallback: ['/ /offline.html'],
//          exclude: ['js/jquery.min.js'],
      preferOnline: false,
      timestamp: true,
      verbose: false,
      hash: true,
      master: ['index.html']
    },
    src: [
      'index.html',
      '{newcomer,expert}/*/*.html',
      'bower_components/*/*',
      'images/**/*',
      'scripts/*.js',
      'styles/*.css',
      '{videos,fonts}/*'
    ],
    dest: '<%= yeoman.dist %>/manifest.appcache'
  }
}

version: 0.4.0

Just tested: also not working with timestamp: false.

I can confirm the issue and it seems like the package just hasn't been updated in the npm registry. @gunta can you please publish a new version?

FYI: Due to no response from the author of this package, I wrote a simple clone that includes a hash option and can be installed from npm. It works fine for me, if you experience any bugs I will gladly fix them.

It appears his NPM repo isnt updated to what he has here on Github.

If you copy tasks/manifest.js contents from this repo, into your copy in node_modules/grunt-manifest/tasks/manifest.js, hashes will work.

@gunta can you update your NPM repo please, so the most recent code you've written is available?