gunta / grunt-manifest

Generates HTML5 Cache Manifest files

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Planning .0.4.x support?

MMRandy opened this issue · comments

I see that the wiki says that this plugin has plans to be included as part of the grunt-contrib series of plugins, which are all supposed to be 0.4.x compatible...yet this one doesn't appear to be there yet. Are plans in the works to make this work in the 4.0 environment? Looks like it needs to build in support for the changes regarding iterating over configuration targets. Also looks like you're already aware of this as I see the following comment in the source:

    // TODO: ditch this when grunt v0.4 is released
    this.files = this.files || helpers.normalizeMultiTaskFiles(this.data, this.target);

Sure hope so as this is a vital plugin for performance of web/mobile apps, IMO :)
Thx!

@gunta, I'm sure you are busy...but but would you mind pinging us back to let us know if you are planning to make this 0.4.x compatible any time soon? This is the only plugin of the 15 or so that I use that is not 0.4.x compatible. I'll be glad to attempt a rewrite if needed, but I just don't want to duplicate the effort if you have already started the process. Thanks for your time and reply in advance :)

Hi! I got really busy but thanks to @saulhardman now it supports Grunt 0.4! Thank you!

Intersting, I wrote my own update for 4.0 as well. I was getting ready to publish mine...does @saulhardman's version install by default now with "npm install grunt-contrib-manifest"? Also, it should be renamed as per the Grunt team's request to not include the "contrib".

It doesn't currently install via that method, no @MMRandy – in order to be able to include it as a dependency or via npm install grunt-contrib-manifest @gunta will have to amend his npm package entry so that it points to the updated version on the repository. Could you do that for us Gunther?

I can also see that there's already a discussion taking place regarding the naming, so I imagine this repository and the npm entry will be changed once a response is received.