Suddenly, strange issues with indentation

Question

Suddenly, strange issues with indentation

mybuddymichael opened this issue 11 years ago · comments

If I take a line line this:

(re-seq #"[A-Z]" (clojure.string/upper-case c)))

and break up the two arguments, I get this:

(re-seq #"[A-Z]"
                  (clojure.string/upper-case c)))

I've noticed it with several other forms and it appears that arguments after newlines always want to start at the 20th column. I'm up-to-date with master, and I get the same result with both Clojure 1.4.0 and 1.5.1.

Sung Pae · Answer 1 · Wed Mar 20 2013 13:53:51 GMT+0800 (China Standard Time)

Hey Michael,

I can't seem to reproduce with that form; could you please tell me the output of vim --version, and perhaps another example?

While we're on the topic, I've noticed other strange problems recently with indentation so I am going to undertake a careful rewrite of the indenting system this weekend along with a test suite.

Michael Hanson · Answer 2 · Thu Mar 21 2013 00:05:18 GMT+0800 (China Standard Time)

I worried that this might be local to my setup...

I'm currently on Vim 7.3.872, and I've discovered that the behavior is caused by something introduced in patch 871. Patch 865 does not have this problem. I'll revert back to 865 for now and monitor future patches to see if it fixes itself.

Thanks and sorry!

Sung Pae · Answer 3 · Thu Mar 21 2013 04:16:19 GMT+0800 (China Standard Time)

It doesn't appear that 7.3.871 has been acknowledged as problematic by the vim_dev mailing list. However, that patch does change a corner case of search(), which is used extensively by the indent script. If this patch really causes this issue, it's definitely a legitimate issue.

I pull from the version kept by b4winckler, but he's been lagging behind the official hg repository (which I guess I will start tracking directly now), so I applied 7.3.871 on top of 7.3.863, and I do see the problem now (although not with your example strangely).

I am going to reopen this until either I fix the problem or report the issue upstream.

Thanks!

Sung Pae · Answer 4 · Sat Mar 23 2013 17:36:12 GMT+0800 (China Standard Time)

This was definitely a bug in 7.3.871. I found the issue and sent it upstream:

https://groups.google.com/d/msg/vim_dev/UNuAJ_lKqng/XRPH6LN9vmQJ

If it gets accepted, I'll close this issue.

Michael Hanson · Answer 5 · Sun Mar 24 2013 04:44:53 GMT+0800 (China Standard Time)

No kidding... Nice work!

hnigit · Answer 6 · Fri Apr 05 2013 01:48:03 GMT+0800 (China Standard Time)

I have been facing the same issue in last several days and noticed Bram committed the fix by Sung Pae as patch 877 yesterday. Just grabbed the latest source code and it's working perfectly. Thanks for the great work!

Sung Pae · Answer 7 · Fri Apr 05 2013 01:58:46 GMT+0800 (China Standard Time)

Ah, that's right, I was supposed to close this. Thanks for reporting Michael; I got to be first in line with a fix in hand.

Michael Hanson · Answer 8 · Fri Apr 05 2013 04:02:33 GMT+0800 (China Standard Time)

No problem. Thanks for the patch.