Feature Request: update to typescript-eslint v4
xiaoxiangmoe opened this issue · comments
Hey, thanks for opening an issue!
Do you think if it is enough to just add v4 to this dependency version range?
eslint-plugin-deprecation/package.json
Line 27 in 3e6f7c3
import type { Observable } from "rxjs";
declare const a: Observable<string>;
a.subscribe({
next: (x) => console.log(x),
});
This will cause error in current version of eslint-plugin-deprecation and latest ts+typescript-eslint.
https://github.com/xiaoxiangmoe/eslint-plugin-deprecation-bug
As you can see, eslint-plugin-deprecation has different result comparing to sonarlint-vscode, which bundle latest sonarjs.
So with latest typescript-eslint
this issue is fixed?
It seems that it works in if we use latest typescript-eslint and latest SonarJS.
@gund Can you update it?
@xiaoxiangmoe can you please confirm if this change is enough?
https://github.com/gund/eslint-plugin-deprecation/pull/20/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R27
@gund It seems that it is not enough. Maybe we should update source codes. see:
https://github.com/SonarSource/SonarJS/blob/3e3a662019d460bef8729f1e88ae82ff70ecf102/eslint-bridge/src/rules/deprecation.ts
What exactly is broken?
I don't know. I have tried to pack a new package and use yarn resolution to replace it, but it is not working.
repo: https://github.com/xiaoxiangmoe/eslint-plugin-deprecation-bug
This is fixed by #39.