peerDependency warning with TypeScript 4

Question

maranomynet opened this issue 4 years ago · comments

I'm using TypeScript 4 in a few projects and it triggers a warning that this plugin specifies TypeScript ^3.7 as a peerDependency.

Should the peerDependency be changed to include TS4?

Alex Malkevich · Answer 1 · Sun Oct 11 2020 22:35:02 GMT+0800 (China Standard Time)

Hey @maranomynet, sure we can add typescript@^4 to the version range.

Just to clarify, does this plugin still work with TS v4?

Also if you want you may submit a PR with this change =)

Már Örlygsson · Answer 2 · Mon Oct 12 2020 07:26:57 GMT+0800 (China Standard Time)

It does seem to work just fine still.

However, similar to VSCode's built in strike-through warning, it only warns about reading deprecated values, but not about writing/setting them.

Which feels a bit strange omission, IMO

Alex Malkevich · Answer 3 · Mon Oct 12 2020 17:19:49 GMT+0800 (China Standard Time)

Thanks for the PR! There is just one little comment.

Regarding deprecated writes it is probably an issue we can open and track.

Már Örlygsson · Answer 4 · Mon Oct 12 2020 20:07:17 GMT+0800 (China Standard Time)

I opened issue #13

Alex Malkevich · Answer 5 · Mon Oct 12 2020 21:06:38 GMT+0800 (China Standard Time)

Great! The PR is merged and new version will be released soon.

Thanks!

Alex Malkevich · Answer 6 · Mon Dec 07 2020 03:00:44 GMT+0800 (China Standard Time)

🎉 This issue has been resolved in version 1.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀