fs::remove_all cannot delete non-directory files

Question

actboy168 opened this issue 5 years ago · comments

Describe the bug
fs::remove_all should allow deletion of a file.

To Reproduce

assert(fs::remove_all("test.txt") == 1)
assert(fs::remove_all("test.txt") == 0)

Expected behavior
But now it will throw an exception.

Additional context

Steffen Schümann · Answer 1 · Tue Mar 05 2019 20:35:13 GMT+0800 (China Standard Time)

Indeed, thanks for reporting! I will push a fix on master when I'm back home and I scheduled a release for next sunday.

actboy168 · Answer 2 · Wed Mar 06 2019 09:47:20 GMT+0800 (China Standard Time)

Hi, it still has a small problem. When removing a file that does not exist, fs::remove_all should return 0, but it is now 1.

Steffen Schümann · Answer 3 · Wed Mar 06 2019 14:07:08 GMT+0800 (China Standard Time)

True, added a test and a fix for that.

Steffen Schümann · Answer 4 · Sun Mar 17 2019 02:20:15 GMT+0800 (China Standard Time)

Closed with release of v1.0.8