Giters

gulrak / filesystem

An implementation of C++17 std::filesystem for C++11 /C++14/C++17/C++20 on Windows, macOS, Linux and FreeBSD.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Undeclared identifier DWORD

Mooseart opened this issue · comments

commented

Hi.
Believe I've found a bug:
Error C2065 'DWORD': undeclared identifier ghc\filesystem.hpp(1089)

Noticed this now (on Windows, vs2019) when upgrading from an older release of your repo.

So I get this when using the forward declarations. Apparently it now relies on having DWORD already defined which wasn't the case before. My application does not include windows.h, hence there's no DWORD.

I see a few options:

  • Change the declaration of make_system_error() to not use DWORD.
  • Include windows.h always, not only for implementation.
  • typedef unsigned long DWORD if not already defined.

Not sure what works best here but the latter two are probably best to avoid if possible.

commented

Thanks for the report! I'll look into it, was a few days and got back with an annoying cold.

commented

Fix released with v1.2.10