Missing include <vector> in forward declarations

Question

Missing include <vector> in forward declarations

Mooseart opened this issue 5 years ago · comments

Seems like std::vector is being used but not included. This is with forward declaration by including ghc/fs_std_fwd.hpp and happens only on Windows.

Check in ghc/filesystem.hpp:1009

Solved by adding #include just before #endif // GHC_EXPAND_IMPL

Steffen Schümann · Answer 1 · Wed May 15 2019 12:15:32 GMT+0800 (China Standard Time)

Indeed, that is missing. In their blog entry to C++17/20 features of VS2019 they saild they rearranged their own headers so they include less, so I guess the error was hidden by former "greediness" of MSVC headers.

Steffen Schümann · Answer 2 · Wed May 15 2019 12:21:51 GMT+0800 (China Standard Time)

Fix with 61182d0 on master. Thank you for reporting.

Mooseart · Answer 3 · Wed May 15 2019 14:16:17 GMT+0800 (China Standard Time)

This problem showed up for me when building with 2017 actually. Maybe the tests include vector on a higher level, or they don't use the forward declaration construct?
Either way, I tested with master now and it compiles fine with vs2017 so I think we can close it. Thanks!