GHC_NO_DIRENT_D_TYPE should be defined on Solaris

Question

GHC_NO_DIRENT_D_TYPE should be defined on Solaris

lhruska opened this issue 2 years ago · comments

Describe the bug
Filesystem fails to compile (filesystem/filesystem.hpp) on Solaris because of missing d_type in dirent structure.

Additional context
Doxygen issue

Steffen Schümann · Answer 1 · Fri Apr 01 2022 23:45:19 GMT+0800 (China Standard Time)

I'll look into it.

Vladislav Shchapov · Answer 2 · Fri Apr 01 2022 23:47:14 GMT+0800 (China Standard Time)

https://github.com/lukyhruska96/doxygen/commit/f751ce0d514def462798352827515126c45037a5

albert-github · Answer 3 · Fri Apr 01 2022 23:50:13 GMT+0800 (China Standard Time)

The reference: doxygen/doxygen@933c0ec is better as here also the GHC_OS_SOLARIS is set

Steffen Schümann · Answer 4 · Sat Apr 02 2022 20:00:42 GMT+0800 (China Standard Time)

I'll decided against another GHC_NO_DIRENT_D_TYPE and instead removed it and implemented compile time detection of the dirent variant. Got the whole test suite to successfully run on a Solaris 10 and hopefully will make a release until tomorrow.
Just need to figure out the GitHub workflow issue with VS2019.

Vladislav Shchapov · Answer 5 · Sat Apr 02 2022 21:36:19 GMT+0800 (China Standard Time)

@gulrak
CentOS 8 build is failed.
Solution: migrate from CentOS 8 to CentOS 8 Stream (like this e8a17c1)

Steffen Schümann · Answer 6 · Sun Apr 03 2022 18:35:26 GMT+0800 (China Standard Time)

Released with v1.5.12.