Normalize paths upon construction without stat object

Question

Normalize paths upon construction without stat object

phated opened this issue 8 years ago · comments

As I brought up in @darsain's PR, I'm not sure we should normalize the history of an object upon construction if no stat object is passed. If the history represents a directory but no stat object is passed, will the paths be normalized incorrectly?

I'd like to get some feedback on this.

Blaine Bublitz · Answer 1 · Thu Sep 08 2016 02:51:10 GMT+0800 (China Standard Time)

Actually, I don't think isDirectory or isSymbolic is used at all in normalization. Always normalizing should be fine.

darsain · Answer 2 · Thu Sep 08 2016 02:59:04 GMT+0800 (China Standard Time)

If the history represents a directory but no stat object is passed, will the paths be normalized incorrectly?

That was the case when we were going with directories always ending in a separator. Since that got dropped, all paths are now going to look consistently the same.

Just search the index.js for isDirectory or isSymbolic and you'll see that there is no code dependent on them, so there is really no need for this issue :)

Blaine Bublitz · Answer 3 · Thu Sep 08 2016 05:06:15 GMT+0800 (China Standard Time)

@darsain yeah, I was noticing that. I think the change just needs to be in the docs. Thanks for following up.