Set absent select option.
LastRide opened this issue · comments
Slava Leonov commented
Garlic.js could set value that not exists for <select>
tag.
The bug is here - https://github.com/guillaumepotier/Garlic.js/blob/master/garlic.js#L191.
Case:
- Create form with
<select>
<option value="1">1</option>
<option value="2">2</option>
<option value="3">3</option>
</select>
- Choose "1" option and submit form.
- Delete
<option>
with value "1" from form. - Open form. You will see that
<select>
would be empty. Garlic.js would set "1" val to<select>
.
And the bug is in the detectConflict()
function. https://github.com/guillaumepotier/Garlic.js/blob/master/garlic.js#L221
It ignores first <option>
value. If selected option would be the first and it's value would not be equals to option value - garlic would ignore this and set unexisting value to <select>
Slava Leonov commented
Up :)