guilhermeaiolfi / flx

A JavaScript router that loves any framework view layer

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Merge params and queryParams

guilhermeaiolfi opened this issue · comments

In the enter hood merge params like:

var params = jQuery.extend(ctx.transition.routes.queryParams, current_route.params);

jQuery is already available. But maybe lodash should be considered.

I saw this and was wondering why not use lodash _.deepClone method instead? I might not have/want jQuery in my project at all.

Yes. Using _.deepClone there and remove the jQuery.on/off`` for thehashchange``` event we could remove the jQuery dep.