Logic bug in node.removeChromeArtifacts()

[Rasmus Schultz]

Possible logic bug here:

      if (!node.getAttribute('style')) {
        node.removeAttribute('style');
      }

I'm not sure what this was intended to do, but it appears to say, "if the node doesn't have the attribute, remove the attribute" - I'm not sure what the intent was, but I don't think this code does anything?

[Robert Rees]

@regiskuckaertz do you remember what this code was trying to achieve?

[Regis Kuckaertz]

@rrees Javascript and type coercion... the empty string is false in JS: this code was meant to eliminate instances of <elem style="">. At least that's what I think.

[Robert Rees]

@regiskuckaertz ah, would it be clearer to have the comparison with the empty string here to avoid people deleting it as a no-op?

[Regis Kuckaertz]

@rrees yes definitely, that's a code smell. I can raise a PR if you want?

[Robert Rees]

@regiskuckaertz that'd be smashing