node.children is undefined?

[Rasmus Schultz]

In this function, did you really mean node or element?

Because Node objects do not have the children property - only Element objects have that.

[Rasmus Schultz]

We probably ought to have an extra function to check if a given node is an HTMLElement, and then use that to make an extra assertion before relying on children - something like:

    function isHTMLElement(node) {
        return node instanceof HTMLElement;
    }

    function isEmptyInlineElement(node) {
        if (isHTMLElement(node)) {
            if (node.children.length > 1) {
                return false;
            }
            if (node.children.length === 1 && node.textContent.trim() !== '') {
                return false;
            }
            if (node.children.length === 0) {
                return node.textContent.trim() === '';
            }
            return isEmptyInlineElement(node.children[0]);
        }
        return false;
    }

[Robert Rees]

I agree with trying to implement the right check

[Kate Whalen]

@rrees adding labels appears to have unassigned you 😢 (that was not intentional)