Giters

gtuk / diga-api-service

This project is a basic api around the excellent diga-api-client It supports validation and billing.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Handling of requests containing test codes

SebastianRehfeldt opened this issue · comments

commented

Sending test codes using this service makes sense to me to try out the different api endpoints and also to test integrations of this service. However, in production setups it might be better to disallow sending requests with test codes. Potential solutions:

  • have a setting which disables sending requests for test codes
  • returning is_test_code in the api responses so it can be handled at caller side.
commented

Really good point. I already had on my internal roadmap. I will most likely go with a setting that is configurable through the env variables to disable test codes

commented

DISABLE_TESTCODES env variable can be set now. Default value is true