Move color logic outside of libadwaita utils/colors into theme package

Question

Move color logic outside of libadwaita utils/colors into theme package

MalcolmMielle opened this issue 2 years ago · comments

For now, the colors used for avatars are hardcoded in utils/colors.dart. The color logic should be delegated to the theme (e.g. yaru or adwaita) and moved out of libawaita.

Prateek Sunal · Answer 1 · Sat Jan 29 2022 19:12:20 GMT+0800 (China Standard Time)

Will yaru theme accept it?

Malcolm Mielle · Answer 2 · Sat Jan 29 2022 22:05:49 GMT+0800 (China Standard Time)

Maybe there is a way to do it. I'm not sure how.

Prateek Sunal · Answer 3 · Mon Feb 14 2022 04:13:42 GMT+0800 (China Standard Time)

I think they should be hardcoded as it is the same for the original libadwaita library:
https://gitlab.gnome.org/GNOME/libadwaita/-/blob/main/src/stylesheet/widgets/_avatar.scss

Prateek Sunal · Answer 4 · Mon Feb 14 2022 04:16:08 GMT+0800 (China Standard Time)

If you disagree, then I will reopen the issue. I am open for suggestions.

Malcolm Mielle · Answer 5 · Mon Feb 14 2022 17:45:11 GMT+0800 (China Standard Time)

Ok sounds good for now :)