Save button makes the file not save

Question

Save button makes the file not save

gibboni opened this issue 6 years ago · comments

gibboni commented 6 years ago

General information

App version: 1.1.0 Google Play Store
System: Android 8.0.0 Sony XZ2 Compact

Description

Steps to reproduce the bug:

Press + to create a new note.
Enter title and some content
Wait for the save icon to be enabled (it is grayed out at start)
Press save icon
Press the back arrow from top
Note is NOT created

The note creation works if I skip steps 3 and 4 and only just press the back arrow. If I wait then the note is not created.

Emanuele Petriglia · Answer 1 · Wed Sep 12 2018 15:13:43 GMT+0800 (China Standard Time)

Same bug. I also notice that if I edit a note with new content, it won't be saved, even if I press the save icon.

System version: LineageOS 14.1 (Android 7.1.2).

Gregor Santner · Answer 2 · Wed Sep 12 2018 15:21:58 GMT+0800 (China Standard Time)

Tried this out and I can only tell that auto save works fine. But it seems like, if the user presses save icon manually at a new document it will not be saved.

Looks like there is a problem in the document filename detection algorithm. Don't use the save button for now please, auto save is still implemented, you don't need the save button.

Gregor Santner · Answer 3 · Wed Sep 12 2018 15:34:28 GMT+0800 (China Standard Time)

The whole dynamic filename logic (when adding new document, writing text on titlebar) is very big and at same time hard to work on. I will make soon what I wanted to make for quite some time:

To make the "+"=new button popup a dialog to enter filename and the type (markdown/plaintext/todo.txt
Directly renaming of filenames only, on accept press, no more file moving at "auto-save" time.

dave · Answer 4 · Wed Sep 12 2018 15:42:07 GMT+0800 (China Standard Time)

just started using this app a few days ago and I didn't know what was going on with that save button but pressing the preview button before you exit seems to save so I've been using that instead :)

Emanuele Petriglia · Answer 5 · Wed Sep 12 2018 16:02:49 GMT+0800 (China Standard Time)

@gsantner I suggest to release quickly a new version that removes temporarily the save button, because I think there are a lot of users that are trapped on this bug.

Also I can suggest to create a beta version to allow some voluntary users to test Markor, before the new version is relased on FDroid and Google Play. Bugs like this could be easily detected.

Alvaro Fernando García · Answer 6 · Sat Sep 15 2018 02:42:30 GMT+0800 (China Standard Time)

It seems auto-save is not working well neither:

I created a note like this
```
some text
```
Then I added more content
```
some text
new content
```
Pressed back and opened note again, result was:
```
some text
```

This happened various times, and the content was lost

Gregor Santner · Answer 7 · Sat Sep 15 2018 03:57:39 GMT+0800 (China Standard Time)

I'm activating history/undo/redo again. seems like the point were it was default-disabled it makes problem on some devices.
I myself tried it multiple/many times now but didn't loose any single character on 1.1.1

Gregor Santner · Answer 8 · Sun Sep 16 2018 03:19:04 GMT+0800 (China Standard Time)

Got email response from some users which told me (auto-)save works fine again now with v1.1.2, so install the fix, or use the preview workaround if you are using F-Droid binary.