validate JSON examples periodically

Question

validate JSON examples periodically

VladimirAlexiev opened this issue 2 years ago · comments

(Spit from #277)

How do we know all examples are valid?

Please add a Makefile to validate all JSON examples against the JSON schema.
Validation should be rerun whenever the schema or the example changes, or a new one is added.

I haven't found any problems in the JSON examples or the JSON schema.
But I'm always a bit pessimistic, so it would be nice to implement such validation.
It's quite possible it'll find some minor deviation somewhere.

@mgh128 @domguinard @jmcanterafonseca-iota @sboeckelmann @shalikasingh @dakbhavesh @CraigRe
Any takers?

jmcanterafonseca-iota · Answer 1 · Tue May 03 2022 14:41:43 GMT+0800 (China Standard Time)

all JSON Examples are validated through this script, nothing is needed https://github.com/gs1/EPCIS/blob/master/JSON-Schema/validate-all.sh

…

On Sun, May 1, 2022 at 4:47 PM Vladimir Alexiev ***@***.***> wrote: (Spit from #277 <#277>) How do we know all examples are valid? - Please add a Makefile to validate all JSON examples against the JSON schema. - Validation should be rerun whenever the schema or the example changes, or a new one is added. I haven't found any problems in the JSON examples or the JSON schema. But I'm always a bit pessimistic, so it would be nice to implement such validation. It's quite possible it'll find some minor deviation somewhere. @mgh128 <https://github.com/mgh128> @domguinard <https://github.com/domguinard> @jmcanterafonseca-iota <https://github.com/jmcanterafonseca-iota> @sboeckelmann <https://github.com/sboeckelmann> @shalikasingh <https://github.com/shalikasingh> @dakbhavesh <https://github.com/dakbhavesh> @CraigRe <https://github.com/CraigRe> Any takers? — Reply to this email directly, view it on GitHub <#430>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQEZJLW2UEDPDQ5PGWI5KC3VH2KP5ANCNFSM5UZ7LRRQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *IOTA Foundation* Pappelallee 78/79 10437 Berlin, Germany Board of Directors: Dominik Schiener, Navin Ramachandran ID/Foundation No.: 3416/1234/2 (Foundation Register of Berlin)

Vladimir Alexiev · Answer 2 · Fri May 06 2022 20:49:27 GMT+0800 (China Standard Time)

@jmcanterafonseca-iota great! Do they all pass?

jmcanterafonseca-iota · Answer 3 · Sat May 07 2022 00:04:39 GMT+0800 (China Standard Time)

yep!

…

On Fri, May 6, 2022 at 2:49 PM Vladimir Alexiev ***@***.***> wrote: @jmcanterafonseca-iota <https://github.com/jmcanterafonseca-iota> great! Do they all pass? — Reply to this email directly, view it on GitHub <#430 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQEZJLQIGGWOMO3KEXMMZ23VIUIOHANCNFSM5UZ7LRRQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- *IOTA Foundation* Pappelallee 78/79 10437 Berlin, Germany Board of Directors: Dominik Schiener, Navin Ramachandran ID/Foundation No.: 3416/1234/2 (Foundation Register of Berlin)