xds: support LRS for all cluster types

Question

xds: support LRS for all cluster types

easwars opened this issue a month ago · comments

Easwar Swaminathan commented a month ago

When working on #7191, I realized that we were setting the LRS server configuration only for EDS clusters. This needs to be supported for all cluster types.

Note that for non-EDS cluster types, there is no locality info, so we default to reporting everything in a single locality name with all fields set to the empty string.

We need to also ensure that we have proper e2e test coverage for all supported cluster types.

Easwar Swaminathan · Answer 1 · Wed May 08 2024 23:49:08 GMT+0800 (China Standard Time)

For aggregate clusters, all configuration comes from the underlying clusters, including LRS.

https://github.com/grpc/proposal/blob/master/A75-xds-aggregate-cluster-behavior-fixes.md contains the latest spec on how aggregate clusters should work. A74 is related as well.

Purnesh Dixit · Answer 2 · Fri May 10 2024 02:25:23 GMT+0800 (China Standard Time)

@easwars shall we close this? I see the related PR is merged

Easwar Swaminathan · Answer 3 · Fri May 10 2024 03:45:36 GMT+0800 (China Standard Time)

That PR does not handle the issue mentioned in here. That PR only adds server config to the ClusterUpdate struct (this work was not done as part of A47, but is required for A71). This issue needs to stay open.

Purnesh Dixit · Answer 4 · Tue May 14 2024 02:16:52 GMT+0800 (China Standard Time)

That PR does not handle the issue mentioned in here. That PR only adds server config to the ClusterUpdate struct (this work was not done as part of A47, but is required for A71). This issue needs to stay open.

Let me know if you think it could be good task for me to look at