Change context import to system context
vanship82 opened this issue · comments
go-grpc-prometheus/server_metrics.go
Line 5 in c225b8c
It breaks the build with grpc v1.18.0
I'm happy with changing to the core package. Wdyt @bwplotka ?
Thanks! Here is another one 👍
go-grpc-prometheus/client_metrics.go
Line 7 in 68e3a13
I think the Golang compatibility is the key question here. We need to choose one (:
Either deprecate old Golang (I think 1.6 or something?) or not allow grpc v1.18.0 ;p
I feel like a new release that goes with gRPC on golang compatiblity side is way to go with this. 👍
Seems like we're in agreement :) let's update