Composite monitors fail the "plan" phase.
zd-carmo opened this issue · comments
Daniel Carmo commented
While creating a composite monitor, it is not possible to run the Plan phase.
This is because it tries to use the "critical" value. - which is usually not defined in a composite monitor (it uses Boolean logic between other monitors to decide when to trigger each level of alerts).
It should be enough if we define the "Critical" property as nil in case the monitor is a composite one (so it won't need to be explicitly dealt with in the rb files).
Michael Grosser commented
sounds good, new logic should go into
kennel/lib/kennel/models/monitor.rb
Line 71 in 735e9f2
Michael Grosser commented
fixed in #84