grosser / kennel

Datadog monitors/dashboards/slos as code, avoid chaotic management via UI

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Composite monitors fail the "plan" phase.

zd-carmo opened this issue · comments

While creating a composite monitor, it is not possible to run the Plan phase.
This is because it tries to use the "critical" value. - which is usually not defined in a composite monitor (it uses Boolean logic between other monitors to decide when to trigger each level of alerts).

It should be enough if we define the "Critical" property as nil in case the monitor is a composite one (so it won't need to be explicitly dealt with in the rb files).

sounds good, new logic should go into

critical: critical

fixed in #84