Should the API always specify the subdomain?

Question

Should the API always specify the subdomain?

Ataraxic opened this issue 10 months ago · comments

I followed the readme and attempted to get Kennel setup.

Our datadog account only exists in us5.

I couldn't get bundle exec rake plan to pass without errors despite setting the subdomain.

I noticed here that we specify the subdomain as app overriding the environment variable because we have the ||= in Utils.

I started a branch and the specs passed. Testing it locally worked for me. Let me know if this is something that would be helpful or if I have misunderstood something.

Thanks.

Justin Sung commented 10 months ago

Yup yup.

Michael Grosser · Answer 1 · Fri Oct 06 2023 02:46:17 GMT+0800 (China Standard Time)

try not setting the subdomain if that works I need to update the docs
afaik subdomain is needed for some legacy accounts

Justin Sung · Answer 2 · Sat Oct 07 2023 02:45:53 GMT+0800 (China Standard Time)

Hello,
I unset the subdomain. Verified with pry in the gem and am getting

Modifying the subdomain to be us5 works for me. I believe our DD account was created this year so I don't believe we are a "legacy" account. Happy to do some more exploration if I can. Lemme know.

Michael Grosser · Answer 3 · Sat Oct 07 2023 02:51:45 GMT+0800 (China Standard Time)

does this maybe do the trick ?

url = Utils.path_to_url("", subdomain: ENV["DATADOG_SUBDOMAIN"] || "app")

... if yes I can see if it works for us too

Michael Grosser · Answer 4 · Wed Nov 08 2023 14:08:07 GMT+0800 (China Standard Time)

confirmed that it's not needed ... was just a leftover from old code 🤷
1.148.0