Giters

grodowski / undercover

undercover warns about methods, classes and blocks that were changed without tests, to help you easily find untested code and reduce the number of bugs. It does so by analysing data from git diffs, code structure and SimpleCov coverage reports

Home Page:https://undercover-ci.com

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong exit status when no changes

grodowski opened this issue · comments

commented

Breaks the master build 😱

$ undercover --compare master
./vendor/bundle/ruby/2.5.0/gems/parser-2.5.1.0/test/test_parser.rb:5306:1-5307:0: error: literal contains escape sequences incompatible with UTF-8
./vendor/bundle/ruby/2.5.0/gems/parser-2.5.1.0/test/test_parser.rb:5306:          \xd0\xd2\xcf\xd7\xc5\xd2\xcb\xc1 = 42
./vendor/bundle/ruby/2.5.0/gems/parser-2.5.1.0/test/test_parser.rb:5306: ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
./vendor/bundle/ruby/2.5.0/gems/parser-2.5.1.0/test/test_parser.rb:5307:          puts \xd0\xd2\xcf\xd7\xc5\xd2\xcb\xc1}.b,
./vendor/bundle/ruby/2.5.0/gems/parser-2.5.1.0/test/test_parser.rb:5307:                                                   
./vendor/bundle/ruby/2.5.0/gems/parser-2.5.1.0/test/test_parser.rb: literal contains escape sequences incompatible with UTF-8 literal contains escape sequences incompatible with UTF-8
./vendor/bundle/ruby/2.5.0/gems/parser-2.5.1.0/test/test_source_buffer.rb:44:9: error: literal contains escape sequences incompatible with UTF-8
./vendor/bundle/ruby/2.5.0/gems/parser-2.5.1.0/test/test_source_buffer.rb:44:         "# \xf9"
./vendor/bundle/ruby/2.5.0/gems/parser-2.5.1.0/test/test_source_buffer.rb:44:         ^~~~~~~~
./vendor/bundle/ruby/2.5.0/gems/parser-2.5.1.0/test/test_source_buffer.rb: literal contains escape sequences incompatible with UTF-8 literal contains escape sequences incompatible with UTF-8
✅ No reportable changes
Undercover finished in 52.043931070000326ms
The command "undercover --compare master" exited with 1.