Suggestion: Add `#[inline(always)]` to most derives
Sympatron opened this issue · comments
Since most derives don't really contain any logic, it would be best to mark then as #[inline] or #[inline(always)] to allow them to be easily optimized away across crates and make them zero cost abstractions.
If you are interested I could work on a PR.
I know that #[inline] is used to instruct compiler to inline functions.
How does it apply to derives? Could you please elaborate on this more?
I mean the implementations of traits nutype generates should have an #[inline] attribute if the are trivial.
I interpret that as "inline functions of traits that nutype generates". (please correct me if that interpretation is wrong).
As far as I know Rust is good at determining what should be inlined automatically.
Could you provide a measuarable example, where inlining of trait methods/functions generated by nutype makes a noticeable difference in performance?
Ok, I checked the implementation generated by Debug and some traits from derive_more. I see what you mean.
If you're fine you can proceed with a PR.
Thanks!
@Sympatron Hi, are you still planning to open a PR for this?
Since I discovered a few other problems with nutype for my use case, I don't really use nutype anymore. So I don't plan on submitting a PR at the moment.
@Sympatron Thanks for the update, no problem at all.
Would you mind describing the problems you have discovered?
It was mostly not very no-std friendly and does not add a const constructor. Apart from that nutype focuses a lot on validation which is probably super useful in some cases, but I just wanted a thin wrapper around a u32 to prevent accidental misuse of my API. So it just wasn't the right fit for me.
@Sympatron Hi, I just published 0.4.1-beta.1 which comes with some support of no_std.
Note:
Stringtype is still not supported inno_stdenvironment.- Use
default-features = falsefornutypedependency