Giters

gretchenfitze / billing-form

Demo page for user-friendly billing form features

Home Page:https://billing-form.herokuapp.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Better BEM

ai opened this issue · comments

commented

Awesome that you use BEM-like isolation. But using real BEM naming could improve readability.

  1. You should use different separator for block/element and between words. card_bank-name instead of card-bank-name. What if you will add card-bank block in future? :D
  2. Avoid nested elements. .card_label instead of .card_date_label.
  3. Avoid global unprefixed styles. .card_label.is-invalid instead of .invalid.