gregsexton / gitv

gitk for Vim.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Exception not caught: fugitive: Removed in favor of fugitive#repo()

dkvasnicka opened this issue · comments

Fugitive recently underwent some major changes and after updating everything and trying to run Gitv I get:

Error detected while processing function <SNR>89_OpenGitv[4]..<SNR>89_SanitizeReservedArgs[16]..<SNR>224_buffer_repo:
line    1:
E605: Exception not caught: fugitive: Removed in favor of fugitive#repo()
Press ENTER or type command to continue

The same error also appears during Gitv_GetDebugInfo() when it tries to get the current git version.

commented

Mostly we use fugitive#buffer().repo() so it's a simple search-and-replace, but we also use fugitive#buffer().path() once. If anyone has a solution please post it here.

we also use fugitive#buffer().path() once.

Looking at tpope/vim-fugitive@d41dee9, it seems like just replace fugitive#buffer().path() with FugitivePath. What do you think?

commented

That will work. We'll need to store the original buffer as well. Pull requests are accepted, I'm not sure when I can work on this.