Add link in README on installing old version of parsack

Question

Add link in README on installing old version of parsack

soegaard opened this issue 5 years ago · comments

Hi Greg,

I think a line in the readme about parsack is needed. Something like:

The Toml parser needs a specific version of the library parsack.
First install parsack as below, then install toml afterwards.

raco pkg install "git://github.com/stchang/parsack#beddbd2ba7de85745c1023a0177d16efd6fe16a1"

/Jens Axel

sorawee · Answer 1 · Sat Aug 17 2019 15:07:29 GMT+0800 (China Standard Time)

Can this be specified in info.rkt so that everything works automatically?

Greg Hendershott · Answer 2 · Sun Aug 18 2019 22:09:29 GMT+0800 (China Standard Time)

I haven't looked at this c. 5 years. (Also, I'm not spending much time with Racket lately because reasons.)

Having said that: Looking now, probably stchang/parsack@ca5b180 is the breaking change. Whatever I did around the same time to accommodate that breaking change, in https://github.com/greghendershott/markdown, could probably be done here. Absent that happening, soon, I guess a README note like you suggest would help.

Greg Hendershott · Answer 3 · Sun Aug 18 2019 22:52:22 GMT+0800 (China Standard Time)

Looking more:

TOML has evolved since TOML 0.2.0, which is what existed when I did this in 2014. Quick glance, there are many new features up through TOML 0.5.0 that this library doesn't attempt to support.

I have no need for any of that, myself. I don't want to work on that.

If someone else wants to volunteer to do all that work? In that case:

I'd be happy to try to do one final commit, that adapts this to use the more-recent parsac, and, clarifies in the README that it's a TOML 0.2.0 parser.
I could archive this repo.
Someone could fork it, and take it from there.

p.s. Keep in mind this is just a GitHub repo -- I never put it on pkgs.racket-lang.org. If someone else wanted to do that, they could; there's nothing that would need to be reassigned.

sorawee · Answer 4 · Sun Aug 18 2019 23:00:28 GMT+0800 (China Standard Time)

A solution that will likely require little time is to change "parsack" to "git://github.com/stchang/parsack#beddbd2ba7de85745c1023a0177d16efd6fe16a1". I just tried it. It works.

Would you want to make this change? And if so, do you prefer me to submit a PR, or would you do it yourself?

Jens Axel Søgaard · Answer 5 · Sun Aug 18 2019 23:38:35 GMT+0800 (China Standard Time)

Hi Greg, Don't spend time fixing anything. We looked at it, and Parsack has changed too much to make a quick fix. Using the old version of Parsack fixes things. There were a beginner in racket.reddit.com who asked for a configuration parser, and toml were suggested - and then we found out Parsack had been updated. A line in the readme is fine. /Jens Axel Den søn. 18. aug. 2019 kl. 17.00 skrev sorawee <notifications@github.com>:

…

A solution that will likely require little time is to change "parsack" <https://github.com/greghendershott/toml/blob/master/info.rkt#L4> to "git://github.com/stchang/parsack#beddbd2ba7de85745c1023a0177d16efd6fe16a1 ". I just tried it. It works. Would you want to make this change? And if so, do you prefer me to submit a PR, or would you do it yourself? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1?email_source=notifications&email_token=AADQXRLOBXS42AXCQJHRFR3QFFPY3A5CNFSM4IMLGGL2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4RBYXQ#issuecomment-522329182>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADQXRM7FEO7NDJXODTBSATQFFPY3ANCNFSM4IMLGGLQ> .

-- -- Jens Axel Søgaard