Docs should warn about quit browser before start/stop daemon ?

Question

Docs should warn about quit browser before start/stop daemon ?

BillDietrich opened this issue 3 years ago · comments

I haven't tested this, but I think bad things could happen if PSD is started or stopped while an applicable browser is running. Shouldn't there be a warning in the docs and Wiki saying something like "Quit out of all browsers before starting or stopping the PSD daemon." ? Otherwise the browser could be using a profile and the daemon suddenly tries to move it to somewhere else.

graysky · Answer 1 · Wed Oct 13 2021 02:02:14 GMT+0800 (China Standard Time)

https://github.com/graysky2/profile-sync-daemon/blob/master/common/profile-sync-daemon.in#L375

Bill Dietrich · Answer 2 · Wed Oct 13 2021 03:15:30 GMT+0800 (China Standard Time)

Okay, thanks. So the code looks like:

if starting PSD and a browser is running, refuse to start PSD.
if stopping PSD and a browser is running, kill the browser.

I guess the 2nd case must do a kill instead of "refuse to stop PSD" because we could be in the middle of shutting down the system ?