Conversion of HSV fails when V = 0

Question

Conversion of HSV fails when V = 0

bdoss opened this issue 7 years ago · comments

This appears to be caused by division by zero, resulting in the saturation component evaluating to NaN.

Line 12 seems to be where the division by zero occurs:
https://github.com/toish/chromatism/blob/488020a1553d5aa0a0ffb1fbd98fc19a6be6503d/src/conversions/hsv.js#L9-L17

Blake Doss · Answer 1 · Tue Oct 24 2017 04:50:27 GMT+0800 (China Standard Time)

Only seems to impact the HSV case.

HSL conversion:

let { hex } = chroma.convert({ h: 0, s: 0, l: 0 });
// hex = #000000

HSV conversion:

let { hex } = chroma.convert({ h: 0, s: 0, v: 0 });
// hex = #NaNNaNNaN

Josh Duff · Answer 2 · Tue Oct 24 2017 05:04:55 GMT+0800 (China Standard Time)

Good catch!

Josh Duff · Answer 3 · Tue Oct 24 2017 05:29:35 GMT+0800 (China Standard Time)

Fix published upstream in chromatism2@3.0.2. Can be cherry-picked/merged from TehShrike@436d8b0

Blake Doss · Answer 4 · Tue Oct 24 2017 05:31:59 GMT+0800 (China Standard Time)

Thanks for the quick fix!

graypegg · Answer 5 · Sun Nov 05 2017 02:39:36 GMT+0800 (China Standard Time)

Awesome! Thanks for the patch @TehShrike, and sorry for the radio silence on my end, this will be in a patch release as soon as I can get to my laptop today.

graypegg · Answer 6 · Sun Nov 05 2017 02:45:10 GMT+0800 (China Standard Time)

Oh wait, @TehShrike, when you’re able to, would you be able to make a pull request? Thanks!